Log panic in fault handlers #10098
Log panic in fault handlers #10098
Conversation
nordic-krch
requested review from
aescolar,
andrewboie,
andyross,
galak,
kgugala,
MaureenHelm,
pgielda,
ramakrishnapallala,
rgundi and
ruuddw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #10098 +/- ##
==========================================
- Coverage 52.48% 52.48% -0.01%
==========================================
Files 213 213
Lines 26135 26137 +2
Branches 5633 5634 +1
==========================================
- Hits 13718 13717 -1
- Misses 10160 10162 +2
- Partials 2257 2258 +1
Continue to review full report at Codecov.
|
include/logging/log_ctrl.h
Outdated
| @@ -66,6 +66,8 @@ int log_set_timestamp_func(timestamp_get_t timestamp_getter, u32_t freq); | |||
| /** | |||
| * @brief Switch logger subsystem to panic mode. | |||
| * | |||
| * Returns immediately if logger already in panic mode. | |||
There was a problem hiding this comment.
Minor grammar thing: "Returns immediately if +the + logger + is + already in panic mode."
include/logging/log_ctrl.h
Outdated
| @@ -66,6 +66,8 @@ int log_set_timestamp_func(timestamp_get_t timestamp_getter, u32_t freq); | |||
| /** | |||
| * @brief Switch logger subsystem to panic mode. | |||
| * | |||
| * Returns immediately if logger already in panic mode. | |||
| * | |||
| * @details On panic logger subsystem informs all backends about panic mode. | |||
There was a problem hiding this comment.
If you feel like correcting also this line: "On panic+, the+ logger [..]"
nordic-krch
force-pushed
the
log_panic
branch
2 times, most recently
from
606eb8b to
62af5d3
Compare
Added LOG_PANIC to fault handlers to ensure that log is flush and logger processes messages in a blocking way in fault handler. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Ensure that only first log_panic() sends panic signal to backends Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
force-pushed
the
log_panic
branch
from
62af5d3 to
01dfab7
Compare
| @@ -299,6 +299,10 @@ void log_panic(void) | |||
| { | |||
| struct log_backend const *backend; | |||
|
|
|||
| if (panic_mode) { | |||
There was a problem hiding this comment.
unfortuantely there are many paths in error handling. So i see scenarios where one fault function which called log_panic will call another one and i don't want to multiple panic calls to backends. Note that we want to enter panic mode as soon as possible to get as much logs as possible (flush as early as possible).
As suggested by @aescolar stripped down version of #10049 with LOG_PANIC() added to fault handlers. Keeping printk messages there (see discussion: #10049 (comment))