Issue 10094 #10327
Issue 10094 #10327
Conversation
Check the return value of close() in socket_dumb_http.c If non-zero, print the error code Fixes zephyrproject-rtos#8413. Signed-off-by: Satya Bhattacharya <[email protected]>
Check for NULL IPv6 addr values from net_if_ipv6_get_ll() in rpl.c If NULL, print a debug statement Fixes zephyrproject-rtos#10094. Signed-off-by: Satya Bhattacharya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10327 +/- ##
==========================================
+ Coverage 53.19% 53.24% +0.05%
==========================================
Files 209 209
Lines 25630 25631 +1
Branches 5537 5538 +1
==========================================
+ Hits 13633 13647 +14
+ Misses 9801 9788 -13
Partials 2196 2196
Continue to review full report at Codecov.
|
|
|
||
| if (addr) { | ||
| net_rpl_dio_send(rpl_default_iface, instance, addr, | ||
| NULL); | ||
| #if defined(CONFIG_NET_STATISTICS_RPL) | ||
| instance->dio_send_pkt++; |
There was a problem hiding this comment.
please indent this line
| #if defined(CONFIG_NET_STATISTICS_RPL) | ||
| instance->dio_send_pkt++; | ||
| #endif | ||
| } else { | ||
| NET_DBG("Sending DIO failed, IPv6 link local " | ||
| "address is NULL"); |
There was a problem hiding this comment.
Is it ok to resubmit with instance->dio_next_delay parameter in this case?
There was a problem hiding this comment.
IF addr is NULL should we?
k_delayed_work_submit(&instance->dio_timer, DIO_TIMEOUT); return;
| @@ -635,12 +635,16 @@ static void dio_timer(struct k_work *work) | |||
| net_if_ipv6_get_ll(rpl_default_iface, | |||
There was a problem hiding this comment.
Please remove the subsys: from "subsys:net: Null pointer dereferences" commit subject, it should be "net: rpl: Null pointer dereferences" instead.
Also add Coverity id to commit body, the syntax is "Coverity-CID: xxxxx"
| @@ -46,6 +46,7 @@ int main(void) | |||
| int serv; | |||
There was a problem hiding this comment.
The patch "samples: net: Check the return value of close()" is already applied, you can remove it from this PR.
Check for NULL IPv6 addr values from net_if_ipv6_get_ll() in rpl.c If NULL, print a debug statement Fixes zephyrproject-rtos#10094. Signed-off-by: Satya Bhattacharya <[email protected]>
|
Not sure what happened here and why this PR was closed, your patch was almost there. |
subsys: net: Null pointer dereferences
Check for NULL IPv6 addr values from net_if_ipv6_get_ll() in rpl.c
If NULL, print a debug statement
Fixes #10094.
Signed-off-by: Satya Bhattacharya [email protected]