logging: init strdup mem_slab with aligned buffer size #10506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using a non-32-bit aligned value as the block size when initializing the strdup mem_slab for Logger. When the non-aligned pointer is being freed, it's converted to a u32_t and this generates the following: ***** USAGE FAULT ***** Unaligned memory access Let's use the aligned buffer size as the block size instead. Signed-off-by: Michael Scott <[email protected]>
mike-scott
added
bug
Codecov Report
@@ Coverage Diff @@
## master #10506 +/- ##
=======================================
Coverage 53.18% 53.18%
=======================================
Files 210 210
Lines 25816 25816
Branches 5682 5682
=======================================
Hits 13731 13731
Misses 9780 9780
Partials 2305 2305
Continue to review full report at Codecov.
|
nordic-krch
approved these changes
Oct 11, 2018
This was referenced Oct 11, 2018
jukkar
approved these changes
Oct 11, 2018
|
This is fixing issue in networking shell, so merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a non-32-bit aligned value as the block size
when initializing the strdup mem_slab for Logger.
When the non-aligned pointer is being freed, it's converted
to a u32_t and this generates the following:
***** USAGE FAULT *****
Unaligned memory access
Let's use the aligned buffer size as the block size instead.
Signed-off-by: Michael Scott [email protected]