Skip to content

ext: debug: segger: Add missing # for else in SEGGER config header #10686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sigvartmh
Copy link
Collaborator

@sigvartmh sigvartmh commented Oct 18, 2018

This commit fixes #10685

Signed-off-by: Sigvart M. Hovland [email protected]

@sigvartmh sigvartmh force-pushed the bugfix/missing-#-in-segger-config branch from 547492c to 961022f Compare October 18, 2018 12:56
@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #10686 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10686      +/-   ##
==========================================
- Coverage   53.24%   53.11%   -0.14%     
==========================================
  Files         214      215       +1     
  Lines       25828    25827       -1     
  Branches     5695     5695              
==========================================
- Hits        13753    13717      -36     
- Misses       9760     9800      +40     
+ Partials     2315     2310       -5
Impacted Files Coverage Δ
include/posix/posix_sched.h 0% <0%> (-100%) ⬇️
lib/posix/pthread_barrier.c 0% <0%> (-100%) ⬇️
lib/posix/pthread_cond.c 62.5% <0%> (-20.84%) ⬇️
lib/posix/pthread.c 68.03% <0%> (-12.33%) ⬇️
subsys/logging/log_output.c 82.14% <0%> (-2.1%) ⬇️
lib/posix/pthread_mutex.c 76.38% <0%> (-1.39%) ⬇️
subsys/net/ip/net_if.c 65.23% <0%> (-0.15%) ⬇️
subsys/net/lib/app/net_app.c 41.62% <0%> (-0.02%) ⬇️
subsys/bluetooth/host/hci_core.c 2.46% <0%> (ø) ⬆️
subsys/bluetooth/common/log.c 0% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae220c...961022f. Read the comment docs.

nashif
nashif previously requested changes Oct 18, 2018
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UC3 Title does not follow [subsystem]: [subject]: "Add missing # for else in SEGGER config header"

@sigvartmh sigvartmh changed the title Add missing # for else in SEGGER config header logging: Add missing # for else in SEGGER config header Oct 19, 2018
@sigvartmh sigvartmh changed the title logging: Add missing # for else in SEGGER config header segger: config: Add missing # for else in SEGGER config header Oct 19, 2018
@sigvartmh sigvartmh changed the title segger: config: Add missing # for else in SEGGER config header ext: debug: segger: Add missing # for else in SEGGER config header Oct 19, 2018
@sigvartmh
Copy link
Collaborator Author

Better now?

@carlescufi
Copy link
Member

@sigvartmh not yet. Please check the CI error log and fix your commit message.

@sigvartmh sigvartmh force-pushed the bugfix/missing-#-in-segger-config branch from 961022f to c6cd44a Compare October 22, 2018 07:34
@sigvartmh
Copy link
Collaborator Author

@nashif This should be fine now or do you just want [subsystem]: [subject]: not the additional specification of ext?

@galak galak dismissed nashif’s stale review October 30, 2018 11:00

issue resolved

@galak galak merged commit 0fe7a98 into zephyrproject-rtos:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing # for else in segger conf
5 participants