drivers: usb: nordic: Fix max packet size handling #10934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelzadrozniak
requested review from
finikorg and
jfischer-no
as code owners
carlescufi
approved these changes
Oct 30, 2018
|
CC @rakons |
carlescufi
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
@pawelzadrozniak could you please add a more detailed description of the change in the commit message?
Codecov Report
@@ Coverage Diff @@
## master #10934 +/- ##
=======================================
Coverage 53.29% 53.29%
=======================================
Files 215 215
Lines 25904 25904
Branches 5710 5710
=======================================
Hits 13805 13805
Misses 9778 9778
Partials 2321 2321Continue to review full report at Codecov.
|
This commit fixes the issue with non-default max packet size (<64). The max packet size value was not passed to low-level driver in norfic hal (nrfx_usbd) causing 64-byte being send regardless of configured endpoint size. Size mismatch results in communication error on Linux hosts. Signed-off-by: Paweł Zadrożniak <[email protected]>
pawelzadrozniak
force-pushed
the
nrfx_usbd_mps_fix
branch
from
7116aef to
4519350
Compare
|
recheck |
1 similar comment
|
recheck |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue with non-default max packet size (<64).
The max packet size value was not passed to low-level driver
in norfic hal (nrfx_usbd) causing 64-byte being send regardless of
configured endpoint size. Size mismatch results in communication
error on Linux hosts.
Signed-off-by: Paweł Zadrożniak [email protected]