net: ipv6: Verify ICMPv6 checksum before accepting packet #10999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
force-pushed
the
bug-10971-icmp-chksum
branch
from
4bb496d to
3ce3942
Compare
Codecov Report
@@ Coverage Diff @@
## master #10999 +/- ##
=========================================
Coverage ? 53.25%
=========================================
Files ? 217
Lines ? 26698
Branches ? 5925
=========================================
Hits ? 14219
Misses ? 10060
Partials ? 2419
Continue to review full report at Codecov.
|
rmstoi
approved these changes
Nov 1, 2018
pfalcon
approved these changes
Nov 1, 2018
Make sure that ICMPv6 checksum is correct before continuing processing the packet. Fixes zephyrproject-rtos#10971 Signed-off-by: Jukka Rissanen <[email protected]>
The ICMP checksum was not placed to correct position in the created test packet. This caused the checksum to be bad, and because we now check the ICMP checksum, the packet was rejected and the mld test failed. Signed-off-by: Jukka Rissanen <[email protected]>
The IPv6 test was failing because the ICMPv6 checksum was wrong. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
bug-10971-icmp-chksum
branch
from
58d9097 to
85190f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that ICMPv6 checksum is correct before continuing
processing the packet.
Fixes #10971
Signed-off-by: Jukka Rissanen [email protected]