Skip to content

RFC: Renaming PM APIs #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2018
Merged

RFC: Renaming PM APIs #11972

merged 2 commits into from
Dec 28, 2018

Conversation

nashif
Copy link
Member

@nashif nashif commented Dec 8, 2018

  • Rename _sys to sys_
  • Rename _sys_soc -> sys_

Fixes #11047

Remove leading underscore from PM APIs. _ was used for internal APIs.

Signed-off-by: Anas Nashif <[email protected]>
sys_soc is just redundant, just call APIs with sys_*.

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif added the DNM This PR should not be merged (Do Not Merge) label Dec 8, 2018
@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #11972 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11972      +/-   ##
==========================================
+ Coverage   48.07%   48.47%   +0.39%     
==========================================
  Files         281      293      +12     
  Lines       43349    50722    +7373     
  Branches    10392    13038    +2646     
==========================================
+ Hits        20841    24586    +3745     
- Misses      18350    21351    +3001     
- Partials     4158     4785     +627
Impacted Files Coverage Δ
kernel/idle.c 100% <ø> (ø) ⬆️
subsys/shell/shell_ops.h 41.79% <0%> (-10.85%) ⬇️
drivers/clock_control/nrf5_power_clock.c 50% <0%> (-2.11%) ⬇️
include/net/net_if.h 62.41% <0%> (-0.41%) ⬇️
include/net/net_pkt.h 85.6% <0%> (-0.25%) ⬇️
include/net/websocket.h 100% <0%> (ø) ⬆️
include/device.h 100% <0%> (ø) ⬆️
include/net/socket.h 100% <0%> (ø) ⬆️
include/logging/log_core.h 100% <0%> (ø) ⬆️
subsys/net/lib/http/http_server.c 52.06% <0%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b28ca...7ec5650. Read the comment docs.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM

@andrewboie
Copy link
Contributor

No objections to this change.
Do we have documentation somewhere which indicates the appropriate use of prefixes (z_, k_, sys_, etc)

Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a safe change to me.

@pizi-nordic pizi-nordic self-requested a review December 12, 2018 15:29
@carlescufi
Copy link
Member

@nashif why is this tagged as DNM?

@nashif nashif removed the DNM This PR should not be merged (Do Not Merge) label Dec 28, 2018
@nashif
Copy link
Member Author

nashif commented Dec 28, 2018

recheck

@nashif nashif merged commit 74a74bb into zephyrproject-rtos:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants