Skip to content

Bluetooth: Mesh: Two fixes for heartbeat publication storage #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

jhedberg
Copy link
Member

@jhedberg jhedberg commented Jan 4, 2019

Two fixes for hearbeat publication storage. @sjanc I think the first one is probably a good candidate for your 1.13.1 PR.

Johan Hedberg added 2 commits January 4, 2019 17:13
This was intended to be an equality comparison and not an assignment.

Signed-off-by: Johan Hedberg <[email protected]>
This fixes usage of an uninitialized variable (to_store) as introduced
by commit bfad2a0.

Fixes zephyrproject-rtos#12314

Signed-off-by: Johan Hedberg <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #12338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12338   +/-   ##
=======================================
  Coverage   48.32%   48.32%           
=======================================
  Files         294      294           
  Lines       44189    44189           
  Branches    10600    10600           
=======================================
  Hits        21354    21354           
  Misses      18569    18569           
  Partials     4266     4266

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4eda5...37a14bf. Read the comment docs.

@jhedberg jhedberg requested a review from carlescufi January 4, 2019 18:17
Copy link
Collaborator

@Vudentz Vudentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhedberg jhedberg merged commit d57a9a6 into zephyrproject-rtos:master Jan 7, 2019
@jhedberg jhedberg deleted the mesh_settings branch January 7, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants