ext: hal: atmel: sam: update to version 2.3.98

[aurel32]

This is an import of Atmel SAM E70 HAL version 2.3.98, and only for the
revision A of the chip. The files have been passed through dos2unix to
minimize the differences with the previous version which seems to also
have been imported that way.

On top of that the following commit has been reapplied:

• 1333061 ("Add missing header files symbols for Atmel SAM E70)"
  => except the DACC alternate pin functions which has been fixed in the
  same way in the new version.

The following commits have not been reapplied, and the README file has
been updated accordingly:

• 9670dc5 (Remove unused and broken preprocesor macros)
  => The macros have been changed from the _U to U style and thus are
  less likely to break compilation with some toolchains.
• 4dcfc87 (Add missing interrupt number definitions)
  => This has been fixed with a slightly different way in the new
  version. This commit also adjusts the names in the ethernet driver.
• 3369a96 ("ext: same70: Add missing PMC_SR_PCKRDY3 define")
  => This has been fixed the same way in the new version.

Signed-off-by: Aurelien Jarno [email protected]

[galak]

On top of that the following commit has been reapplied:

• 1333061 ("Add missing header files symbols for Atmel SAM E70)"
  => except the DACC alternate pin functions which has been fixed in the
  same way in the new version.

can this be an actual commit?

[codecov-io]

Codecov Report

Merging #12750 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12750   +/-   ##
=======================================
  Coverage   53.51%   53.51%           
=======================================
  Files         239      239           
  Lines       26983    26983           
  Branches     6518     6518           
=======================================
  Hits        14440    14440           
  Misses       9879     9879           
  Partials     2664     2664

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4036339...94e35c3. Read the comment docs.

[aurel32]

On top of that the following commit has been reapplied:

• 1333061 ("Add missing header files symbols for Atmel SAM E70)"
  => except the DACC alternate pin functions which has been fixed in the
  same way in the new version.

can this be an actual commit?

I can indeed split that into a separate commit, however that means the intermediate commits won't build. Is it acceptable?

[aurel32]

@galak I have just pushed a new version that split out the HAL update from the other patches. Note that these commits are not bisectable anymore, ie the ethernet driver won't compile with intermediate commits.

[mnkp]

This looks good with a minor remark regarding commit title. "ext: hal: atmel: sam: re-add missing header files following HAL import" should be better changed to "ext: hal: atmel: sam: re-add missing header symbols" since we are adding symbols not files.

[aurel32]

This looks good with a minor remark regarding commit title. "ext: hal: atmel: sam: re-add missing header files following HAL import" should be better changed to "ext: hal: atmel: sam: re-add missing header symbols" since we are adding symbols not files.

@mnkp Thanks for the review. That is a good point, I have just fixed that.

[dgloeck]

The new rev A headers move the GMAC ISRPQ, TBQBAPQ, RBQBAPQ, and RBSRPQ registers by 4 bytes. Can anyone confirm that this is correct for revision A?

The 2.3.98 headers for revision B also put the registers at the new addresses. This contradicts the data sheet.

Ok, this is already mentioned in #12945.

[aurel32]

@dgloeck Yes, that has been fixed by #13126. I have opened a case at microchip, not sure it will work though.