Skip to content

drivers: counter: Fix default top value callback in counter_nrfx_rtc.c #12815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nordic-krch
Copy link
Collaborator

In case of default top value, driver was calling top value
callback only on the first period. This was not expected behavior.

Fixes #12800.

Signed-off-by: Krzysztof Chruscinski [email protected]

In case of default top value, driver was calling top value
callback only on the first period. This was not expected behavior.

Signed-off-by: Krzysztof Chruscinski <[email protected]>
@nordic-krch nordic-krch requested review from pabigot and anangl January 29, 2019 11:41
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work. The documentation still needs to be clarified but we can do that separately; to discuss in API call.

@codecov-io
Copy link

Codecov Report

Merging #12815 into topic-counters will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           topic-counters   #12815      +/-   ##
==================================================
+ Coverage           53.53%   53.96%   +0.43%     
==================================================
  Files                 243      242       -1     
  Lines               28380    27671     -709     
  Branches             6957     6720     -237     
==================================================
- Hits                15192    14934     -258     
+ Misses              10342     9932     -410     
+ Partials             2846     2805      -41
Impacted Files Coverage Δ
subsys/net/lib/sockets/sockets.c 36.36% <0%> (-12.79%) ⬇️
lib/os/fdtable.c 29.21% <0%> (-2.25%) ⬇️
include/kernel.h 94.44% <0%> (-1.94%) ⬇️
subsys/bluetooth/host/hci_core.c 2.64% <0%> (-1.68%) ⬇️
subsys/net/ip/net_if.c 61.42% <0%> (-0.08%) ⬇️
include/atomic.h 100% <0%> (ø) ⬆️
include/net/socket.h 100% <0%> (ø) ⬆️
subsys/net/ip/connection.c 74.6% <0%> (ø) ⬆️
subsys/net/ip/tcp.c 57.05% <0%> (ø) ⬆️
subsys/net/lib/sockets/sockets_select.c
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d90fd...23af696. Read the comment docs.

@carlescufi carlescufi merged commit ede64d6 into zephyrproject-rtos:topic-counters Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants