drivers: Changed return statement in function get_timeout() #13597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Review history of this comment for details about previous failed status. |
maxxlife
force-pushed
the
coverity-fix-188890
branch
8 times, most recently
from
9e488ed to
75554b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #13597 +/- ##
=======================================
Coverage 52.45% 52.45%
=======================================
Files 322 322
Lines 46592 46592
Branches 10768 10768
=======================================
Hits 24442 24442
Misses 17247 17247
Partials 4903 4903Continue to review full report at Codecov.
|
maxxlife
force-pushed
the
coverity-fix-188890
branch
4 times, most recently
from
53f6c60 to
e9ed3b7
Compare
According to the Coverity issue 188890 (github issue zephyrproject-rtos#10705) Fix for overflowed or truncated value count-1U used as return value. I decided to use a saturating subtract to avoid a vulnerability. It will always return 0 or bigger value according to the conditions. Now if count value is 0, function will return 0, not -1 as before. Signed-off-by: Maksim Masalski <[email protected]>
maxxlife
force-pushed
the
coverity-fix-188890
branch
from
e9ed3b7 to
cf17643
Compare
nashif
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for overflowed or truncated value count-1U used as return value.
I decided to use a saturating subtract to avoid a vulnerability.
It will always return 0 or bigger value according to the conditions.
Now if count value is 0, function will return 0, not -1 as before.
Coverity-CID: 188890
Fixes: #10750
Signed-off-by: Masalski Maksim [email protected]