Bluetooth: settings: Fix missing log_strdup() call #13612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bt_settings_encode_key() cannot know if the given path pointer is on the stack or not, so the only safe way to pass it to the logger is by using a log_strdup() call. Not doing this will likely cause corrupted strings to show up in the log output. Signed-off-by: Johan Hedberg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #13612 +/- ##
==========================================
- Coverage 52.45% 52.45% -0.01%
==========================================
Files 322 322
Lines 46592 46592
Branches 10768 10768
==========================================
- Hits 24442 24441 -1
Misses 17247 17247
- Partials 4903 4904 +1
Continue to review full report at Codecov.
|
Qbicz
approved these changes
Feb 21, 2019
Laczen
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bt_settings_encode_key() cannot know if the given path pointer is
on the stack or not, so the only safe way to pass it to the logger is
by using a log_strdup() call. Not doing this will likely cause
corrupted strings to show up in the log output.
Signed-off-by: Johan Hedberg [email protected]