arch: arm: nxp: mpu: fix constant expression result errors #13909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
added
bug
galak
approved these changes
Feb 27, 2019
andrewboie
approved these changes
Feb 27, 2019
MaureenHelm
reviewed
Feb 27, 2019
| if (_region_allocate_and_init(index, | ||
| (const struct nxp_mpu_region *)&added_sram_region) | ||
| == -EINVAL) { | ||
| return -EINVAL; | ||
| } |
There was a problem hiding this comment.
Would a better fix be:
if (_region_allocate_and_init(index,
(const struct nxp_mpu_region *)&added_sram_region)
< 0) {
return -EINVAL;
}??
There was a problem hiding this comment.
Yes, that's fine, i will apply this.
This commit fixes two Constant Expression Result errors, in the NXP MPU driver due to incompatible integer types. Fixes zephyrproject-rtos#13836. Fixes zephyrproject-rtos#13865. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
force-pushed
the
arch_arm_nxp_mpu_coverity_issues_1
branch
from
4b5b519 to
552141e
Compare
ioannisg
commented
Feb 28, 2019
There was a problem hiding this comment.
@MaureenHelm, updated, based on your suggestion, pls, revisit.
Codecov Report
@@ Coverage Diff @@
## master #13909 +/- ##
==========================================
- Coverage 52.29% 52.25% -0.04%
==========================================
Files 307 307
Lines 45429 45429
Branches 10506 10506
==========================================
- Hits 23756 23740 -16
- Misses 16887 16899 +12
- Partials 4786 4790 +4
Continue to review full report at Codecov.
|
MaureenHelm
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two Constant Expression Result errors,
in the NXP MPU driver due to incompatible integer types.
Fixes #13836.
Fixes #13865.
Signed-off-by: Ioannis Glaropoulos [email protected]