x86: fix pte corruption when setting large regions #14011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a copy of the flags field for ever PTE we are updating, we can't just keep OR-ing in the address field. Fixes issues seen when setting flags for memory regions larger than a page. Signed-off-by: Andrew Boie <[email protected]>
andrewboie
added
bug
Codecov Report
@@ Coverage Diff @@
## master #14011 +/- ##
=======================================
Coverage 52.27% 52.27%
=======================================
Files 307 307
Lines 45467 45467
Branches 10525 10525
=======================================
Hits 23768 23768
Misses 16901 16901
Partials 4798 4798Continue to review full report at Codecov.
|
andrewboie
added
priority: high
nashif
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a copy of the flags field for every PTE we are
updating, we can't just keep OR-ing in the address
field.
Fixes issues seen when setting flags for memory regions
larger than a page.
Signed-off-by: Andrew Boie [email protected]