Skip to content

shell: fix coverity issue #14035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jakub-uC
Copy link
Collaborator

@jakub-uC jakub-uC commented Mar 4, 2019

Fixing a case where variable could be used without an initialization.

Fixes: #13831

Fixing a case where variable could be used without an initialization.

Signed-off-by: Jakub Rzeszutko <[email protected]>
@jakub-uC jakub-uC requested a review from nordic-krch as a code owner March 4, 2019 10:42
@jakub-uC jakub-uC requested review from carlescufi and nashif March 4, 2019 10:43
@jakub-uC jakub-uC added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Shell Shell subsystem Coverity A Coverity detected issue or its fix labels Mar 4, 2019
@jakub-uC jakub-uC added this to the v1.14.0 milestone Mar 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #14035 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14035      +/-   ##
==========================================
+ Coverage   52.27%   52.27%   +<.01%     
==========================================
  Files         307      307              
  Lines       45467    45468       +1     
  Branches    10525    10525              
==========================================
+ Hits        23768    23769       +1     
  Misses      16901    16901              
  Partials     4798     4798
Impacted Files Coverage Δ
subsys/shell/shell.c 21.52% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fd80a...1c6ff08. Read the comment docs.

@nashif nashif merged commit 4fb20c4 into zephyrproject-rtos:master Mar 4, 2019
@jakub-uC jakub-uC deleted the shell_fix_coverity_issue branch March 4, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants