include/kernel.h: Remove unsupported return values from k_work APIs #14182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing in the code actually returns -EINPROGRESS, and in the case of k_work_init() I don't see how that can even be done in a reliable way. Don't claim we do what we don't. Fixes zephyrproject-rtos#14109. Signed-off-by: Andy Ross <[email protected]>
andrewboie
approved these changes
Mar 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #14182 +/- ##
=======================================
Coverage 52.68% 52.68%
=======================================
Files 307 307
Lines 45473 45473
Branches 10530 10530
=======================================
Hits 23956 23956
Misses 16640 16640
Partials 4877 4877
Continue to review full report at Codecov.
|
pizi-nordic
approved these changes
Mar 8, 2019
nashif
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing in the code actually returns -EINPROGRESS, and in the case of
k_work_init() I don't see how that can even be done in a reliable way.
Don't claim we do what we don't. Fixes #14109.
Signed-off-by: Andy Ross [email protected]