Bluetooth: controller: Workaround multi-link DLE assert #14553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexsven could you verify if this is a suitable workaround in comparison to commenting out the assert? |
jhedberg
requested changes
Mar 15, 2019
| */ | ||
| LL_ASSERT(0); | ||
| return -EAGAIN; |
There was a problem hiding this comment.
This doesn't look right. You changed the return value of this function to u32_t but here you're returning a negative value?
There was a problem hiding this comment.
Oversight, will fix it. Thank you. Changed the return type to int.
cvinayak
force-pushed
the
github_dle_assert_fix
branch
from
881f968 to
206c35a
Compare
Workaround from asserting when Rx PDU buffers from pool needing resize is acquired by another connection. By skipping the connection events to give some headroom for the host to process the Rx packets and eventually make the pool available for resize. Fixes zephyrproject-rtos#11841. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_dle_assert_fix
branch
from
206c35a to
0f44aa2
Compare
jhedberg
approved these changes
Mar 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #14553 +/- ##
==========================================
- Coverage 52.02% 51.98% -0.04%
==========================================
Files 309 309
Lines 45574 45575 +1
Branches 10555 10555
==========================================
- Hits 23711 23694 -17
- Misses 17057 17070 +13
- Partials 4806 4811 +5
Continue to review full report at Codecov.
|
aescolar
added
bug
|
@cvinayak |
carlescufi
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround from asserting when Rx PDU buffers from pool
needing resize is acquired by another connection. By
skipping the connection events to give some headroom for
the host to process the Rx packets and eventually make the
pool available for resize.
Fixes #11841.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]