Skip to content

userspace: private identifier naming fixes #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

andrewboie
Copy link
Contributor

@andrewboie andrewboie commented Mar 15, 2019

  • Some private macros for userspace were prefixed by underscores, with number of underscores indicating indirection levels. These all now start with Z_

  • Syscall handler functions now are prefixed with z_hdlr_ instead of hdlr_

Fixes: #14447

Andrew Boie added 2 commits March 15, 2019 10:43
These private macros are now all prefixed with Z_.

Fixes: zephyrproject-rtos#14447

Signed-off-by: Andrew Boie <[email protected]>
Now prefixed with z_hdlr_ instead of just hdlr_.

Signed-off-by: Andrew Boie <[email protected]>
@andrewboie andrewboie requested a review from andyross as a code owner March 15, 2019 17:50
@andrewboie andrewboie requested review from ceolin, pfl, nashif and galak March 15, 2019 17:50
@andrewboie andrewboie added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Memory Protection area: MISRA-C labels Mar 15, 2019
@andrewboie andrewboie added this to the v1.14.0 milestone Mar 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #14585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14585   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files         309      309           
  Lines       45576    45576           
  Branches    10554    10554           
=======================================
  Hits        23683    23683           
  Misses      17083    17083           
  Partials     4810     4810

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350f6f7...53ea301. Read the comment docs.

@andrewboie andrewboie merged commit 7ea2112 into zephyrproject-rtos:master Mar 18, 2019
@andrewboie andrewboie deleted the syscall-namespace branch April 24, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Memory Protection area: MISRA-C bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename macro functions starting with two or three underscores
7 participants