subsys: logging: defines clean up #14607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@galak could you try it with clang? |
jakub-uC
reviewed
Mar 18, 2019
| #define CONFIG_LOG_BACKEND_RTT_RETRY_CNT 10 | ||
| #endif | ||
|
|
||
| #define DROP_MAX 99 | ||
|
|
||
| #define DROP_MSG "\nmessages dropped: \r" |
There was a problem hiding this comment.
I know that it is not part of this change, but do you know what is a purpose of \r at the end?
|
All checks are passing now. Review history of this comment for details about previous failed status. |
Codecov Report
@@ Coverage Diff @@
## master #14607 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 309 309
Lines 45048 45048
Branches 10419 10419
=======================================
Hits 23656 23656
Misses 16584 16584
Partials 4808 4808Continue to review full report at Codecov.
|
|
@nordic-krch any plans to update? |
nordic-krch
force-pushed
the
log_rtt_define_cleanup
branch
from
02d653c to
358c4a2
Compare
RTT backend supports two modes blocking and drop. Apparently, defines used lead to warning while clang compilation. Define that caused warning has been changed together with clean up which removed #ifdefs for definitions. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
force-pushed
the
log_rtt_define_cleanup
branch
from
358c4a2 to
064f513
Compare
|
@galak did you tried it with clang. Is the warning fixed? |
galak
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTT backend supports two modes blocking and drop. Apparently,
defines used lead to warning while clang compilation. Define
that caused warning has been changed together with clean up
which removed #ifdefs for definitions.
Fixes #14536
Signed-off-by: Krzysztof Chruscinski [email protected]