Bluetooth: Mesh: Increase advertising thread stack size #14680
Conversation
subsys/bluetooth/host/mesh/adv.c
Outdated
| @@ -45,7 +45,11 @@ | |||
| #define ADV_INT_DEFAULT_MS 100 | |||
| #define ADV_INT_FAST_MS 20 | |||
|
|
|||
| #ifdef CONFIG_BT_HOST_CRYPTO | |||
There was a problem hiding this comment.
minor thing: we've tried to be consistent with #if defined(CONFIG_...) in the Bluetooth code, could you please do that? (benefit is that you can combine multiple defined(...) conditions for a single #if but not with #ifdef)
With BT_HOST_CRYPTO, advertising stack size could be overflowed, increase size to 1024 when BT_HOST_CRYPTO is enabled. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
mesh_fix_adv_stack
branch
from
7279c6a to
e83b3a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #14680 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 309 309
Lines 45584 45584
Branches 10555 10555
=======================================
Hits 23694 23694
Misses 17082 17082
Partials 4808 4808Continue to review full report at Codecov.
|
|
@sjanc @Vudentz @carlescufi could we get a second review on this? A month ago or so it was discovered that the stack requirement for advertising had grown, see commit 1cfa122, however turns out we still need the conditionally higher size for BT_HOST_CRYPTO. |
With BT_HOST_CRYPTO, advertising stack size could be overflowed,
increase size to 1024 when BT_HOST_CRYPTO is enabled.
Signed-off-by: Erwan Gouriou [email protected]