samples: Bluetooth: hci_uart: Implement NOP Command Complete #14682
Conversation
carlescufi
force-pushed
the
cc-nop-hci-uart
branch
from
2931508 to
bfb4415
Compare
Codecov Report
@@ Coverage Diff @@
## master #14682 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 309 309
Lines 45584 45584
Branches 10555 10555
=======================================
Hits 23694 23694
Misses 17082 17082
Partials 4808 4808Continue to review full report at Codecov.
|
carlescufi
force-pushed
the
cc-nop-hci-uart
branch
from
bfb4415 to
d720395
Compare
|
This should address #15333. |
carlescufi
force-pushed
the
cc-nop-hci-uart
branch
from
d720395 to
429aaab
Compare
| }, | ||
| .cc = { | ||
| .ncmd = 1, | ||
| .opcode = BT_OP_NOP, |
There was a problem hiding this comment.
I know that it makes no difference in practice, however this should really be sys_cpu_to_le16(BT_OP_NOP) to keep track of what endianness .opcode is.
There was a problem hiding this comment.
Is this actually allowed on an initializer?
There was a problem hiding this comment.
On big endian this maps to __bswap_16() which is defined as follows:
#define __bswap_16(x) ((u16_t) ((((x) >> 8) & 0xff) | (((x) & 0xff) << 8)))
I'd think the compiler should be able to handle that even for the initialiser of a const variable, but you could always try it by using __bswap_16(BT_OP_NOP)
There was a problem hiding this comment.
It is. Updated, thanks!
carlescufi
force-pushed
the
cc-nop-hci-uart
branch
from
429aaab to
a173a09
Compare
| }; | ||
|
|
||
| for (i = 0; i < sizeof(cc_evt); i++) { | ||
| uart_poll_out(hci_uart_dev, *(((u8_t *)&cc_evt)+i)); |
There was a problem hiding this comment.
(const u8_t *), just for consistency
Implement the Controller counterpart to CONFIG_BT_WAIT_NOP so that it issues a NOP Command Complete event after booting up, to signal to the Host that it is ready to receive HCI traffic. Fixes zephyrproject-rtos#15333 Signed-off-by: Carles Cufi <[email protected]>
In order to fit in SRAM, reduce the CONFIG_BT_MAX_CONN from 20 to 16 in the configuration used for the BBC micro:bit. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
cc-nop-hci-uart
branch
from
9246da2 to
23f3fdb
Compare
Implement the Controller counterpart to CONFIG_BT_WAIT_NOP so that it
issues a NOP Command Complete event after booting up, to signal to the
Host that it is ready to receive HCI traffic.
Fixes #15333
Signed-off-by: Carles Cufi [email protected]