Bluetooth: Fix missing return statement in le_conn_param_req() #14757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The le_conn_param_req() function was missing a return statement in case of a failed connection lookup. This could lead to replying to the connection parameter request twice as well as passing NULL to bt_conn_unref(). The latter issue also triggered a Coverity warning. Fixes CID 196638 Signed-off-by: Johan Hedberg <[email protected]>
jhedberg
added
bug
Codecov Report
@@ Coverage Diff @@
## master #14757 +/- ##
==========================================
- Coverage 52.5% 52.5% -0.01%
==========================================
Files 309 309
Lines 45047 45047
Branches 10418 10418
==========================================
- Hits 23654 23653 -1
- Misses 16586 16587 +1
Partials 4807 4807
Continue to review full report at Codecov.
|
mped-oticon
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The le_conn_param_req() function was missing a return statement in
case of a failed connection lookup. This could lead to replying to the
connection parameter request twice as well as passing NULL to
bt_conn_unref(). The latter issue also triggered a Coverity warning.
Fixes CID 196638
Signed-off-by: Johan Hedberg [email protected]