Bluetooth: Fix several issues related to initialization with BT_SETTINGS #14834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedberg
added
bug
jhedberg
force-pushed
the
bt_settings_init
branch
3 times, most recently
from
2acd8f8 to
dcc09f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #14834 +/- ##
==========================================
+ Coverage 52.49% 52.52% +0.03%
==========================================
Files 309 309
Lines 45056 45063 +7
Branches 10432 10434 +2
==========================================
+ Hits 23651 23669 +18
+ Misses 16592 16583 -9
+ Partials 4813 4811 -2
Continue to review full report at Codecov.
|
jhedberg
force-pushed
the
bt_settings_init
branch
from
dcc09f1 to
7bc6977
Compare
added 2 commits
March 24, 2019 19:35
The treatment of the BT_DEV_READY flag was broken when used together with BT_SETTINGS. The flag would get set even though the stack was still in a partially initialized state. Even worse, for central role the stack would potentially try to initiate passive scanning without having an identity address. Refactor the code that sets the BT_DEV_READY flag (among other initialization) into a separate bt_finalize_init() helper function and call it when the settings have been loaded. Also clarify the warning message given to the user in case settings_load() needs to be called. Signed-off-by: Johan Hedberg <[email protected]>
Several public APIs were not checking the BT_DEV_READY flag, which could lead to hard-to-debug behavior, particularly when the stack lacks an identity address. Add the appropriate checks to these APIs. Signed-off-by: Johan Hedberg <[email protected]>
jhedberg
force-pushed
the
bt_settings_init
branch
from
7bc6977 to
e2c982c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two patches fix several critical details when it comes to initializing the stack when BT_SETTINGS is used.
Fixes #14833