logging: Clarify contract of log_output_func_t #14919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Review history of this comment for details about previous failed status. |
nashif
approved these changes
Mar 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #14919 +/- ##
=========================================
Coverage ? 52.84%
=========================================
Files ? 309
Lines ? 45247
Branches ? 10447
=========================================
Hits ? 23909
Misses ? 16574
Partials ? 4764Continue to review full report at Codecov.
|
galak
approved these changes
Mar 26, 2019
carlescufi
force-pushed
the
log-output-func
branch
from
7f79987 to
26c6505
Compare
carlescufi
changed the title
carlescufi
force-pushed
the
log-output-func
branch
from
26c6505 to
2185f32
Compare
The log_output_func_t backend function is supposed to either process or drop bytes and return the amount of those to the caller. Clarify this in the documentation. Fixes zephyrproject-rtos#12241 Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
log-output-func
branch
from
2185f32 to
8c6da79
Compare
nordic-krch
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log_output_func_t backend function is supposed to either process or
drop bytes and return the amount of those to the caller. Clarify this in
the documentation.
Fixes #12241
Signed-off-by: Carles Cufi [email protected]