Bluetooth: ipsp: Fix not checking return of build_reply #15004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vudentz is there not a matching GitHub issue for this? AFAIK one was created for all Coverity issues. Please reference it so that it gets automatically closed once this PR is merged. |
jhedberg
added
bug
I probably miss that then, will take a look. |
|
@jhedberg updated with issue number. |
net_pkt_sendto uses size_t as parameter for len so the value would be treat as unsigned which may cause and invalid memory to be read. Fixes zephyrproject-rtos#14950 zephyrproject-rtos#14955 Signed-off-by: Luiz Augusto von Dentz <[email protected]>
jhedberg
approved these changes
Mar 29, 2019
tbursztyka
approved these changes
Mar 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #15004 +/- ##
=======================================
Coverage 52.92% 52.92%
=======================================
Files 309 309
Lines 45268 45268
Branches 10451 10451
=======================================
Hits 23956 23956
Misses 16544 16544
Partials 4768 4768Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net_pkt_sendto uses size_t as parameter for len so the value would be
treat as unsigned which may cause and invalid memory to be read.
Fixes #14950
Fixes #14955
Signed-off-by: Luiz Augusto von Dentz [email protected]