Net services should start after the stack is fully ready #15141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2019 09:03
Just provide a macro of value 0 in case CONFIG_NET_DHCPV4 is unset. Signed-off-by: Tomasz Bursztyka <[email protected]>
DNS is not part of L3, but as dhcpv4 or the net shell, it is a services on top of the network stack. So let's gather all in a dedicated function. This also rework the order when starting the DNS service. There was an issue for offload device: these would be fully initialized in init_rx_queues() which was called after l3_init. l3_init had already started dns: which would not be able to bind correctly, proving to be fully dead afterwards. Instead, starting the dns at the very end ensures that all is initialized properly from devices to stack. Fixes zephyrproject-rtos#15124 Signed-off-by: Tomasz Bursztyka <[email protected]>
tbursztyka
added
bug
jukkar
approved these changes
Apr 3, 2019
rveerama1
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing net "servicing" starting order.
Fixes #15124