kernel: demote K_THREAD_STACK_BUFFER() to private #15195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewboie
requested review from
aescolar,
andyross,
galak,
jukkar,
kgugala,
MaureenHelm,
nashif,
nategraff-sifive,
pfalcon,
pgielda,
ramakrishnapallala,
rgundi,
ruuddw,
tbursztyka and
vonhust
as code owners
andrewboie
requested review from
ioannisg
and removed request for
nategraff-sifive
andrewboie
force-pushed
the
remove-k-thread-stack-buffer
branch
from
8c50ffa to
70f6a47
Compare
|
All checks are passing now. Review history of this comment for details about previous failed status. |
andrewboie
force-pushed
the
remove-k-thread-stack-buffer
branch
from
70f6a47 to
4120d3d
Compare
andyross
approved these changes
Apr 5, 2019
jukkar
approved these changes
Apr 5, 2019
ruuddw
approved these changes
Apr 5, 2019
ioannisg
reviewed
Apr 5, 2019
include/kernel.h
Outdated
| /* Stack Start - Identical to K_THREAD_STACK_BUFFER() on the stack | ||
| * object. Represents thread-writable stack area without any extras. | ||
| */ | ||
| /* Represents thread-writable stack area without any extras */ |
There was a problem hiding this comment.
The comment is more suitable for the documentation of the whole thread_stack_info struct
As is. it refers to the start variable.
Therefore, you could perhaps update it as "Stack start. - Represents the start address of the thread-writable stack area..."
ioannisg
reviewed
Apr 5, 2019
This macro is slated for complete removal, as it's not possible on arches with an MPU stack guard to know the true buffer bounds without also knowing the runtime state of its associated thread. As removing this completely would be invasive to where we are in the 1.14 release, demote to a private kernel Z_ API instead. The current way that the macro is being used internally will not cause any undue harm, we just don't want any external code depending on it. The final work to remove this (and overhaul stack specification in general) will take place in 1.15 in the context of zephyrproject-rtos#14269 Fixes: zephyrproject-rtos#14766 Signed-off-by: Andrew Boie <[email protected]>
andrewboie
force-pushed
the
remove-k-thread-stack-buffer
branch
from
4120d3d to
df96ef7
Compare
nashif
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro is slated for complete removal, as it's not possible
on arches with an MPU stack guard to know the true buffer bounds
without also knowing the runtime state of its associated thread.
As removing this completely would be invasive to where we are
in the 1.14 release, demote to a private kernel Z_ API instead.
The current way that the macro is being used internally will
not cause any undue harm, we just don't want any external code
depending on it.
The final work to remove this (and overhaul stack specification in
general) will take place in 1.15 in the context of #14269
Fixes: #14766
Signed-off-by: Andrew Boie [email protected]