arch: arm: add initial support for CONFIG_USERSPACE #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add related configs & (stub) functions for enabling CONFIG_USERSPACE on arm w/o build errors. Signed-off-by: Chunlin Han <[email protected]>
chunlinhan
requested review from
andrewboie,
galak and
MaureenHelm
as code owners
andrewboie
reviewed
Sep 26, 2017
| /* the _current might be NULL before the first thread is scheduled if | ||
| * CONFIG_ARCH_HAS_CUSTOM_SWAP_TO_MAIN is enabled. | ||
| */ | ||
| if (!_current) { |
There was a problem hiding this comment.
bleah. don't like adding overhead here just for a situation that only happens in the pre-boot environment.
i believe it's the call to k_object_grant_access() in setup_new_thread() which does this.
i'll take this for now, but I'm going to optimize this away later. #4082 will track it.
andrewboie
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add related configs & (stub) functions for enabling
CONFIG_USERSPACE on arm w/o build errors.
Signed-off-by: Chunlin Han [email protected]