Revert "Bluetooth: gatt: ccc changed cb after connection cb" #44015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6bb75a5. This fixes GATT that was uninitalized when application received bt_conn_cb->connected callback. As the result, the bt_gatt_is_subscribed was not working as expected when called from bt_conn_cb->connected. The _bt_gatt_ccc->cfg_changed callback does not carry information about the device that subscribed for notifications but rather is says the app when it should start/stop broadcasting notifications. This leads to the conclusion that the bt_gatt_ccc->cfg_changed can be called before bt_conn_cb->connected callback. Fixes: zephyrproject-rtos#42829 Signed-off-by: Mariusz Skamra <[email protected]>
MariuszSkamra
requested review from
alwa-nordic,
jhedberg and
Vudentz
as code owners
jhedberg
approved these changes
Mar 21, 2022
Thalley
approved these changes
Mar 21, 2022
alwa-nordic
approved these changes
Mar 21, 2022
|
I created a PR with new doc for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6bb75a5.
This fixes GATT that was uninitalized when application received
bt_conn_cb->connected callback. As the result, the bt_gatt_is_subscribed
was not working as expected when called from bt_conn_cb->connected.
The _bt_gatt_ccc->cfg_changed callback does not carry information about
the device that subscribed for notifications but rather is says the
app when it should start/stop broadcasting notifications.
This leads to the conclusion that the bt_gatt_ccc->cfg_changed can be
called before bt_conn_cb->connected callback.
Fixes: #42829
Signed-off-by: Mariusz Skamra [email protected]