cmake: Execute arch/CMakeLists.txt before subsys/CMakeList.txt #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
reviewed
Jan 9, 2018
CMakeLists.txt
Outdated
| @@ -297,8 +297,8 @@ add_subdirectory(misc) | |||
| include(misc/generated/CMakeLists.txt) | |||
| add_subdirectory(boards) | |||
| add_subdirectory(ext) | |||
| add_subdirectory(subsys) | |||
| add_subdirectory(arch) | |||
There was a problem hiding this comment.
Seems like 'arch' should be first before boards, etc.. and we should add a comment about why its first here.
galak
requested changes
Jan 9, 2018
Re-order the execution of the arch/ and subsys/ CMakeLists.txt code to work around a manifestation of issue zephyrproject-rtos#6505. When OpenThread created an External project in subsys, it did not have access to important toolchain flags added in arch/. Intuitively, subsystems might depends on how the ARCH is configured, but the ARCH shouldn't depend on any subsystem. Signed-off-by: Sebastian Bøe <[email protected]>
SebastianBoe
force-pushed
the
cmake_reorder_arch_and_subsys
branch
from
89db4df to
fe8ee98
Compare
Codecov Report
@@ Coverage Diff @@
## master #5609 +/- ##
==========================================
- Coverage 53.56% 53.55% -0.01%
==========================================
Files 428 428
Lines 41191 41191
Branches 7856 7856
==========================================
- Hits 22062 22060 -2
- Misses 19018 19020 +2
Partials 111 111
Continue to review full report at Codecov.
|
nashif
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-order the execution of the arch/ and subsys/ CMakeLists.txt code to
work around a manifestation of issue #5605 . When OpenThread created an
External project in subsys it did not have access to important
toolchain flags added in arch/.
Intuitively, subsystems might depends on how the ARCH is configured,
but the ARCH shouldn't depend on any subsystem.
Signed-off-by: Sebastian Bøe [email protected]