Skip to content

soc: esp32c3: add __text_region_start & __text_region_end #71363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ycsin
Copy link
Member

@ycsin ycsin commented Apr 11, 2024

Add these to the esp32c3 linker scripts to make the implementations consistent across for RISCV SOCs.

This is spinned off from #69912

@ycsin ycsin requested review from sylvioalves and marekmatej April 11, 2024 03:03
@ycsin ycsin added area: RISCV RISCV Architecture (32-bit & 64-bit) platform: ESP32 Espressif ESP32 labels Apr 11, 2024
@@ -133,6 +133,7 @@ SECTIONS
. += 16;

_text_end = ABSOLUTE(.);
__text_region_end = .;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marekmatej after #70505 (7ecc715), there's _text_end in the zephyr/soc/espressif/esp32c3/mcuboot.ld but the _text_start is now gone, could you please advise how to do this now? Cheers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ycsin, is the symbol needed to be in the mcuboot.ld at all?
I made a mistake by removing it from the default.ld. Please take a look at the fix #71388

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR.

Hi @ycsin, is the symbol needed to be in the mcuboot.ld at all?

Looks like it is used in MCUBOOT image only, probably not required.

@ycsin ycsin force-pushed the pr/esp_text_region branch from 3040af9 to 52d4966 Compare April 11, 2024 03:39
Add these to the esp32c3 linker scripts to make the
implementations consistent across for RISCV SOCs.

Signed-off-by: Yong Cong Sin <[email protected]>
@ycsin ycsin force-pushed the pr/esp_text_region branch from 52d4966 to 9aa4e35 Compare April 11, 2024 03:41
@ycsin ycsin changed the title soc: esp32c3: add __text_region_start & __text_region_end soc: esp32c3: add __text_region_start & __text_region_end Apr 11, 2024
@ycsin ycsin closed this Apr 11, 2024
@ycsin ycsin deleted the pr/esp_text_region branch April 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RISCV RISCV Architecture (32-bit & 64-bit) platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants