drivers: timer: Use global sys_clock_hw_cycles_per_tick in nrf_rtc_tmer. #8249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8249 +/- ##
=======================================
Coverage 64.53% 64.53%
=======================================
Files 420 420
Lines 40122 40122
Branches 6763 6763
=======================================
Hits 25892 25892
Misses 11110 11110
Partials 3120 3120Continue to review full report at Codecov.
|
pizi-nordic
force-pushed
the
nrf-rtc-timer-fix
branch
from
75e2985 to
7f13573
Compare
pizi-nordic
requested review from
nvlsianpu,
cvinayak,
carlescufi and
anangl
and removed request for
nvlsianpu
drivers/timer/nrf_rtc_timer.c
Outdated
| /* Maximum difference for RTC counter values used. Half the maximum value is | ||
| * selected to be able to detect overflow (a negative value has the same | ||
| * representation as a large positive value). | ||
| */ | ||
| #define RTC_MASK 0x00FFFFFF |
There was a problem hiding this comment.
This should not be moved here, since the comment above is for RTC_HALF, not for this one.
Perhaps it would be better to move it to the line after #define RTC_CC_EVENT.
There was a problem hiding this comment.
@anangl: Fixed. Thank you for spotting that. I misunderstood comment and thought that it should be moved.
pizi-nordic
force-pushed
the
nrf-rtc-timer-fix
branch
from
7f13573 to
8cfe0b1
Compare
drivers/timer/nrf_rtc_timer.c
Outdated
| @@ -55,6 +49,8 @@ static u32_t expected_sys_ticks; | |||
| s32_t _get_max_clock_time(void); | |||
| #endif /* CONFIG_TICKLESS_KERNEL */ | |||
|
|
|||
| extern s32_t _sys_idle_elapsed_ticks; | |||
There was a problem hiding this comment.
Isn't it redundant? It is declared in system_timer.h which is included above.
The nrf_rtc_timer used own method to calculate number of timer cycles per tick. As the result value was different than the one used by the kernel, the reported time was incorrect. This commit fixes the problem described above by using global sys_clock_hw_cycles_per_tick instead of custom RTC_TICKS_PER_SYS_TICK. Signed-off-by: Piotr Zięcik <[email protected]>
pizi-nordic
force-pushed
the
nrf-rtc-timer-fix
branch
from
8cfe0b1 to
56c2c82
Compare
The nrf_rtc_timer used own method to calculate number of timer cycles
per tick. As the result value was different than the one used by
the kernel, the reported tick time was incorrect.
This commit fixes the problem described above by using sys_clock_hw_cycles_per_tick
instead of custom RTC_TICKS_PER_SYS_TICK define.
Signed-off-by: Piotr Zięcik [email protected]
Note: Together with #8259 this commit solves timer issues on Nordic SoCs in non-tickless mode. Patches for tickless configuration will follow.