ext: stm32cube: stm32f4xx: shift I2SR field in PLLI2SCFGR register #8762
Conversation
|
@erwango It would be nice if we could get a number before the end of the week. |
| is read or written. | ||
| Impacted files: | ||
| drivers/include/stm32f4xx_ll_rcc.h | ||
| ST Bug tracker ID: TO BE ASSIGNED |
There was a problem hiding this comment.
Provided internal ST tracker.
ok, good.
Do you know if this bug is also present for other series
Well, no, I don't know.
I can check it quickly tomorrow. Let's say that the PLLI2S is not present in all the series if I got it properly. Maybe only stm32f4xx and stm32f10x. But I need to check carefully.
|
@erwango |
Codecov Report
@@ Coverage Diff @@
## master #8762 +/- ##
=======================================
Coverage 52.36% 52.36%
=======================================
Files 195 195
Lines 24713 24713
Branches 5136 5136
=======================================
Hits 12940 12940
Misses 9699 9699
Partials 2074 2074Continue to review full report at Codecov.
|
|
@avisconti , could you create the same patch in this PR for F7 series as well? Thanks! |
The I2SR field should be shifted by RCC_PLLI2SCFGR_PLLI2SR_Pos when the PLLI2SCFGR register is read or written. Without this patch the PLLI2S configuration is not done properly (R and M params are badly set) and the PLLI2S generates bad clock waveform. ST Bug tracker ID: 50086 Signed-off-by: Armando Visconti <[email protected]>
The I2SR field should be shifted by RCC_PLLI2SCFGR_PLLI2SR_Pos when the PLLI2SCFGR register is read or written. Without this patch the PLLI2S configuration is not done properly (R and M params are badly set) and the PLLI2S generates bad clock waveform. ST Bug tracker ID: 50108 Signed-off-by: Armando Visconti <[email protected]>
|
@erwango |
This PR is fixing two bugs into ST CubeMX code for stm32f4xx and stm32f7xx. Both the two bugs are related to the routines to configure the PLLI2S where the PLLR field was not properly shifted.
ST BUG Tracker IDs: 50108 and 50086