Adding SiWx917 Network Stack Application APIs #89716
Open
+609
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker,
mnkp,
rettichschnidi,
rlubos and
yonsch
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
3f908db to
8d5e691
Compare
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_silabs
DNM (manifest)
|
@ragurram26 please provide a more detailed PR & commit message description, explaining the background to this, why this is needed, etc. Also most people in a Zephyr context won't know what "TA" is, so you need to explain that as well. If you're adding new APIs (like the title implies) I'd also expect to see some sample code to demonstrate their usage and provide code coverage for CI. |
|
One other thing: when you have to enumerate multiple independent changes in a single commit message (like you're doing now), it's a clear indication that you should split this up into multiple commits. |
jhedberg
reviewed
May 9, 2025
drivers/wifi/siwx91x/siwx91x_wifi.c
Outdated
| @@ -139,10 +139,10 @@ static unsigned int siwx91x_on_join(sl_wifi_event_t event, | |||
| if (IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_NATIVE)) { | |||
| net_if_dormant_off(sidev->iface); | |||
| } | |||
|
|
|||
| #ifndef CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD | |||
There was a problem hiding this comment.
Could this use if (!IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_NET_STACK_OFFLOAD)) {?
ragurram26
changed the title
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
8d5e691 to
8b9c083
Compare
|
@jhedberg I have updated the description .
|
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
8b9c083 to
6966645
Compare
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
f464d3d to
ee877f9
Compare
To support the SiWx917 SNTP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Co-authored-by: Swami Das Nampalli <[email protected]> Signed-off-by: Swami Das Nampalli <[email protected]> Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 HTTP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Co-authored-by: Swami Das Nampalli <[email protected]> Signed-off-by: Swami Das Nampalli <[email protected]> Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 MQTT Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
ee877f9 to
9d1e3a7
Compare
To support the SiWx917 ICMP Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
9d1e3a7 to
2605581
Compare
To support the SiWx917 Websockets Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
2605581 to
fa99358
Compare
To support the SiWx917 MDNS Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
fa99358 to
594923e
Compare
To support the SiWx917 DNS Network Stack Application protocol offloading, we need to integrate the Silicon Labs APIs, so adding the corresponding source files and include files in the kconfig and CMakelist Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 TLS Sockets , Need to enable the TLS bitmap in the intilization Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 Single TLS Sockets, Need to enable the Single TLS bitmap in the intilization Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
594923e to
59bb2ac
Compare
To support the SiWx917 Three SSL Sockets, Need to enable the Three SSL bitmap in the intilization Signed-off-by: Rahul Gurram <[email protected]>
To support the SiWx917 SSL high streaming throughput, Need to enable the high streaming bitmap in the intilization Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
59bb2ac to
fa2d6b6
Compare
To support the SiWx917 Multiple TLS version, Need to enable the SSL version bitmap in the intilization Signed-off-by: Rahul Gurram <[email protected]>
Added support for 16K SSL record sizes, which improves performance for SSL connections that use larger record sizes Signed-off-by: Rahul Gurram <[email protected]>
Added support to allocate additional memory for SSL/TLS connections, typically required for connections to cloud servers Signed-off-by: Rahul Gurram <[email protected]>
Added support to Configure number of selects in SiWx917 Signed-off-by: Rahul Gurram <[email protected]>
Added support to Configure number of sockets in SiWx917 Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
4 times, most recently
from
547fbbc to
623719a
Compare
This application demonstrates support for SiWx91x ICMP and DNS protocols Co-authored-by: Swami Das Nampalli <[email protected]> Signed-off-by: Swami Das Nampalli <[email protected]> Signed-off-by: Rahul Gurram <[email protected]>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
623719a to
c498dcd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the SiWx917 Network Stack Application
protocol offloading, we need to add the Silicon Labs APIs,
so adding the corresponding source files and include files