drivers: nrf_ironside dvfs service #90755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anangl,
hubertmis,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
nordic-krch
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
a862e9c to
e437124
Compare
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
e437124 to
414e418
Compare
|
This is adding a new public API, needs WG review... |
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
3 times, most recently
from
3dd1d79 to
c07633d
Compare
carlescufi
removed
the
Architecture Review
|
Long-term discussion here: #91373 For now this can go in as-is, since this is a completely SoC-specific API. |
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
c07633d to
12cc67a
Compare
bjarki-andreasen
requested changes
Jun 11, 2025
| if (!sdfw_dvfs_is_abb_locked(NRF_ABB)) { | ||
| return -IRONSIDE_DVFS_ERROR_BUSY; | ||
| } | ||
|
|
There was a problem hiding this comment.
use k_is_in_isr here and remove mutex
soc/nordic/nrf54h/Kconfig
Outdated
| @@ -28,7 +28,6 @@ config SOC_NRF54H20_CPUAPP_COMMON | |||
| select HAS_SEGGER_RTT if ZEPHYR_SEGGER_MODULE | |||
| select NRFS_HAS_AUDIOPLL_SERVICE | |||
| select NRFS_HAS_CLOCK_SERVICE | |||
| select NRFS_HAS_DVFS_SERVICE | |||
There was a problem hiding this comment.
remove this, with #91187 it will not be needed :)
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
3 times, most recently
from
61d636a to
debce5e
Compare
Added handling of new IRONside DVFS service. NRFS DVFS is now not enabled by default. Signed-off-by: Łukasz Stępnicki <[email protected]>
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
debce5e to
3fd61cb
Compare
|
bjarki-andreasen
approved these changes
Jun 11, 2025
| hsfll_trim.tcoef = NRF_FICR->TRIM.APPLICATION.HSFLL.TRIM.TCOEF; | ||
| #endif | ||
| #else | ||
| #error "Only application core is supported for DVFS" |
There was a problem hiding this comment.
This check may be redundant since kconfig already depends on SOC_NRF54H_CPUAPP
carlescufi
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of new IRONside DVFS service.
NRFS DVFS is now not enabled by default.