kernel: Migrate to new logging subsys #9359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate from SYS_LOG to LOG logging mechanism. Signed-off-by: Olivier Martin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9359 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 201 201
Lines 25359 25359
Branches 5299 5299
=======================================
Hits 13320 13320
Misses 9944 9944
Partials 2095 2095Continue to review full report at Codecov.
|
nordic-krch
approved these changes
Aug 10, 2018
pizi-nordic
approved these changes
Aug 10, 2018
nashif
requested changes
Sep 4, 2018
There was a problem hiding this comment.
the commit is talking about kernel, yet I only see one file being changed and then the module is called userspace. why userspace? why not kernel?
Looks like this lonely log call needs to be converted to a printk instead which later will be used as an alias to kernel logger
|
addressed in #10029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
SYS_LOGtoLOGlogging mechanism.Signed-off-by: Olivier Martin [email protected]