Skip to content

fix: app crash when reach last index of undo stack #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pongstr
Copy link
Contributor

@pongstr pongstr commented Dec 13, 2024

before after
Screen.Recording.2024-12-13.at.09.57.02.mov
Screen.Recording.2024-12-13.at.09.59.04.mov

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for zmk-studio ready!

Name Link
🔨 Latest commit 5dc3d28
🔍 Latest deploy log https://app.netlify.com/sites/zmk-studio/deploys/677c387b9db53900080ebcbf
😎 Deploy Preview https://deploy-preview-111.preview.zmk.studio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pongstr pongstr marked this pull request as ready for review December 13, 2024 08:00
@pongstr pongstr requested a review from Nicell December 15, 2024 09:20
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@petejohanson
Copy link
Collaborator

@pongstr Can you please fix this to only include the actual bug fix, so this can be reviewed? Thanks.

@pongstr
Copy link
Contributor Author

pongstr commented Jan 6, 2025

@petejohanson updated the PR. thanks!

Copy link
Collaborator

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 3370faa into zmkfirmware:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants