Skip to content

Fix tooltip spacing #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AdityaMalik7
Copy link

@AdityaMalik7 AdityaMalik7 commented Jun 26, 2025

Fixes: Tooltip spacing issue for organization/add organization button in the sidebar.
Previously, the tooltip was flush against the sidebar, unlike other sidebar buttons (e.g., Settings, DND, Back, Reload).
This PR introduces proper spacing so that the tooltip now aligns consistently with others, improving visual coherence and user experience.


📸 Before vs. After

Before (tooltip flush) After (proper spacing)
Before Tooltip After Tooltip

🧪 Platforms this PR was tested on:

  • Linux (Ubuntu-based)
  • Linux (Arch)
  • Windows
  • macOS

🧠 Self-review checklist
  • Self-reviewed the changes for clarity and maintainability (e.g., variable names, readability, minimal duplication).
  • Clearly explains differences from previous behavior (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Flags any remaining decisions, assumptions, or concerns.
  • Automated tests verify logic where appropriate.

🧩 Commit discipline:

  • Each commit represents a coherent change.
  • Commit messages explain the reasoning and motivation for the changes.

🧪 Manual review and testing includes:

  • Visual appearance of the fix.
  • Responsiveness and internationalization.
  • Tooltip behavior and string correctness.
  • End-to-end interaction of relevant buttons.
  • Corner cases, error conditions, and potential edge bugs.

@AdityaMalik7
Copy link
Author

Hi @zulip/desktop-team 👋

This PR fixes the tooltip spacing issue for the organization and Add Organization buttons in the sidebar.
All checks have passed ✅ and the spacing now aligns consistently with other sidebar tooltips (Settings, DND, etc.).
Screenshots have been added to show the before and after states.

Tested on:

  • Ubuntu-based Linux
  • Arch Linux
  • macOS

Requesting your review when you get a chance. Thanks!

@alya
Copy link
Collaborator

alya commented Jun 26, 2025

@shubham-padia Could you please take a look to at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants