Document that Message is not exact
#4121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't do anywhere near enough validation of data from the Zulip server. Make a note of this in the definition of `Message`, lest it be marked exact.
`Message` itself isn't exact (q.v.). This isn't much of a problem, since we don't ever construct `Message` values... except in tests. Tighten the typing on our `Message`-creation helpers to only accept values that are documented to be part of `Message`. Fix the (fortunately harmless) bug which this catches in the outbox- reducer tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up in conversation more than once, and should probably be noted in the code.