Skip to content

build(cmake): add option to use system installed Zycore #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

Tachi107
Copy link
Contributor

@Tachi107 Tachi107 commented Oct 8, 2021

This requires a Zycore version with zyantific/zycore-c#33 applied

@Tachi107 Tachi107 force-pushed the build-cmake-system-zycore branch from 2895ed6 to f6b51d0 Compare October 9, 2021 11:47
@athre0z athre0z added A-build Area: Build system C-enhancement Category: Enhancement of existing features P-medium Priority: Medium labels Oct 9, 2021
@athre0z athre0z self-assigned this Oct 9, 2021
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@Tachi107 Tachi107 force-pushed the build-cmake-system-zycore branch from f6b51d0 to a07c051 Compare October 17, 2021 12:43
@athre0z athre0z merged commit ab535b1 into zyantific:master Oct 17, 2021
@Tachi107 Tachi107 deleted the build-cmake-system-zycore branch October 17, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-enhancement Category: Enhancement of existing features P-medium Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants