Add unions in decoded instruction and operands #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athre0z
added
C-enhancement
athre0z
force-pushed
the
refactor/unions-in-public-api
branch
2 times, most recently
from
42309dc to
abb2f2e
Compare
Because Windows still has trouble with compiling C11 code 11 years after the standard was released, we instead rely on the non-standard extension of anonymous unions being supported by MSVC since basically forever. Doing so produces a warning in kernel builds, so we need to shut that up.
athre0z
force-pushed
the
refactor/unions-in-public-api
branch
from
abb2f2e to
6474ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds anonymous unions to the operand struct and the vector-extension structs within the
rawstruct, reducing the struct size quite substantially. For the operands, I also moved thetypefield immediately in front of the union, which should allow us to represent it as a safe union in the Rust bindings without need for calling an accessor.Anonymous unions are a C11 feature, so I had to bump the "required compiler standard" in the process. Because MSVC doesn't properly support C11, we instead rely on the non-standard extension here, silencing the corresponding warning.