Simplify formatter interface #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two functions only differed by one argument.
athre0z
force-pushed
the
simplify-formatter-interface
branch
from
66fe25e to
cc08e78
Compare
athre0z
added
C-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Exvariants of various formatter functions. Their functionality is instead integrated into the non-Exvariant. Having theExvariants effectively doubled the complexity of our public formatter interface and each only had a single additional argument. This additional argument can trivially be passed with asNULL, which I believe should be intuitive to most seasoned C programmers.When porting the various examples I varied between using
NULLandZYAN_NULL. I chose one or the other depending on whether the example otherwise prefers Zycore or standard C constructs. We should probably normalize that across all examples at some point.