Use ZYAN_DIV64 in ZydisStringAppendDecU64 #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the follow up PR! Could you please include the submodule update? It's safe to use the latest We will push a proper version tag to both repositories as soon as we do a new Zydis release 🙂 |
Avoid a direct 64bit integer division in ZydisStringAppendDecU64 and use the macro provided by zycore instead, as GCC might generate unwanted calls to arithmetic functions on 32bit platforms.
|
Updated, thanks! |
athre0z
added
C-enhancement
athre0z
pushed a commit
that referenced
this pull request
Feb 4, 2024
* Update zycore submodule * Use ZYAN_DIV64 in ZydisStringAppendDecU64 Avoid a direct 64bit integer division in ZydisStringAppendDecU64 and use the macro provided by zycore instead, as GCC might generate unwanted calls to arithmetic functions on 32bit platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a direct 64bit integer division in ZydisStringAppendDecU64 and use the macro provided by zycore instead, as GCC might generate unwanted calls to arithmetic functions on 32bit platforms.
This is the Zydis counterpart of zyantific/zycore-c#62
Note that this PR needs an update of the dependencies/zycore submodule first.
Thanks.