Skip to content

Add ZYDIS_BUILD_TESTS option and include tests in CMakeLists.txt #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2023

Conversation

topazus
Copy link
Contributor

@topazus topazus commented Apr 30, 2023

No description provided.

@athre0z athre0z added C-enhancement Category: Enhancement of existing features A-build Area: Build system labels May 20, 2023
@athre0z athre0z self-assigned this May 20, 2023
@athre0z
Copy link
Member

athre0z commented May 20, 2023

Thanks, that's good to have! I added two more commits to also rework our convenience Makefile and the CI to go via the CMake testing path for the sake of de-duplication.

Edit: Ah, there appear to be issues on Windows.. let me see if I can find out what's the issue there.

@athre0z
Copy link
Member

athre0z commented May 20, 2023

Ok, it's also working on Windows now. I had to replace the literal python3 with the variable populated by find_package(Python ...), add generator expressions for the executable paths (on Windows the executables are placed into sub-directories of the output directory) and add if (TARGET xyz) guards to make sure it doesn't break when e.g. the encoder is disabled.

@athre0z athre0z merged commit 2b0d557 into zyantific:master May 20, 2023
@topazus
Copy link
Contributor Author

topazus commented May 21, 2023

Thanks for the review and further improvement.

@topazus topazus deleted the add-tests branch May 21, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-enhancement Category: Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants