Post editor: Open support links in Help Center #43883

mmtr · 2025-06-10T15:37:24Z

Proposed changes:

This PR ensures that a couple of support links in the post editor are opened directly in the Help Center rather than on a new tab.

Excerpts

Before	After
Screen.Recording.2025-06-10.at.16.50.00.mov	Screen.Recording.2025-06-10.at.17.05.14.mov

Tags

Before	After
Screen.Recording.2025-06-10.at.17.05.32.mov	Screen.Recording.2025-06-10.at.17.05.52.mov

It also refactors another couple of links that were already opening the support articles in the Help Center, so they all use the same React component:

SEO	Block guide

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Apply these changes to your WP.com site
Go to the post editor
Open the post settings sidebar
Open the Except panel
Click on the "Learn more about manual excerpts" link
Make sure the support article is opened in the Help Center
Open the Tags panel now
Click on the "Build your audience with tags" link
Make sure the support article is opened in the Help Center
Open the Jetpack settings sidebar
Open the SEO panel
Click on the "Learn more about the SEO feature" link
Make sure there are no regressions, and the support article keeps opening in the Help Center
Insert an embed block
Open the block settings sidebar
Observe the block description
Click on the "Block guide" link
Make sure there are no regressions, and the support article keeps opening in the Help Center

github-actions · 2025-06-10T15:38:21Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: July 1, 2025
- Code freeze: June 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-06-10T15:39:22Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotsup-57-master-list-open-support-links-in-help-center-modal branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack dotsup-57-master-list-open-support-links-in-help-center-modal

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotsup-57-master-list-open-support-links-in-help-center-modal

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jp-launch-control · 2025-06-10T15:50:59Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/extensions/plugins/ai-content-lens/extend/ai-post-excerpt/index.tsx	0/70 (0.00%)	0.00%	-1 💚
projects/plugins/jetpack/extensions/plugins/seo/components/upsell.js	0/12 (0.00%)	0.00%	-5 💚

1 file is newly checked for coverage.

File	Coverage
projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx	0/9 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

… need fixing before

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx

Copilot

Pull Request Overview

This PR updates the post editor to open WP.com support links in the Help Center and refactors support link components to ensure a consistent approach across the codebase.

Refactored support link usage to use the new reusable WpcomSupportLink component.
Updated multiple components and changelogs to redirect support links directly to the Help Center.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
projects/plugins/jetpack/extensions/plugins/seo/components/upsell.js	Replaced manual Help Center logic with WpcomSupportLink for SEO upsell support links.
projects/plugins/jetpack/extensions/plugins/ai-content-lens/extend/ai-post-excerpt/index.tsx	Updated Docs link logic to use WpcomSupportLink for atomic/simple sites and ExternalLink otherwise.
projects/plugins/jetpack/changelog/dotsup-57-master-list-open-support-links-in-help-center-modal	Added changelog entry reflecting the Help Center support articles change.
projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-description-links/src/description-support-link.tsx	Updated inline support link component to use WpcomSupportLink.
projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-description-links/index.tsx	Adjusted import path to the updated description support link component.
projects/packages/jetpack-mu-wpcom/src/features/tags-education/tags-education.js	Replaced ExternalLink with WpcomSupportLink for tags education support links.
projects/packages/jetpack-mu-wpcom/changelog/dotsup-57-master-list-open-support-links-in-help-center-modal	Updated changelog entry for tags education.
projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx	New component that centralizes support link behavior.
projects/js-packages/shared-extension-utils/src/components/index.js	Updated export to include WpcomSupportLink.
projects/js-packages/shared-extension-utils/changelog/dotsup-57-master-list-open-support-links-in-help-center-modal	Added changelog entry for the new WpcomSupportLink component.

Comments suppressed due to low confidence (1)

projects/plugins/jetpack/extensions/plugins/ai-content-lens/extend/ai-post-excerpt/index.tsx:233

[nitpick] Consider using localizeUrl for the URL instead of the __() function to maintain consistency with other parts of the codebase that use localizeUrl for support links.

<WpcomSupportLink url={ __( 'https://wordpress.com/support/excerpts/', 'jetpack' ) } postId={ 1569 } text={ __( 'Learn more about manual excerpts', 'jetpack' ) } />

alshakero

Looks great and will make the experience much better. Found one issue that will probably create a bug.

...jetpack-mu-wpcom/src/features/wpcom-block-description-links/src/description-support-link.tsx

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx

BogdanUngureanu · 2025-06-11T08:20:52Z

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx

+ * @param {object}   [props.style]   - CSS properties to be applied to the link.
+ * @return {React.JSX.Element} The component to render.
+ */
+export function WpcomSupportLink( { url, postId, text, onClick, style } ) {


There's an InlineSupportLink component in Calypso that, I believe, does the same thing. if we can't share it, can we at least have an equivalent component with the same props and behavior :) ?

Yeah, it cannot be re-used because it relies on Calypso state.

I can make it more similar, but it won't be 1:1 equivalent:

The Calypso component supports more scenarios like a more granular control over the text and the icon, but that's not needed so far in Jetpack.

I'm also reluctant to adding a generic event tracking to the component like in Calypso, because Jetpack is already tracking events for some of the links outside of the component, but they all use a different event name, so we cannot consolidate that inside the component.

Adding support for the style prop (as opposed to className like in Calypso) is also convenient because that way we don't need to change how the assets files are built for the wpcom-block-description-links feature.

The Jetpack component lives in the shared extensions package which is used by both Jetpack and WPCOM (I initially added it to jetpack-mu-wpcom, but that doesn't work in the SEO panel logic that is implemented in Jetpack-the-plugin). However, the link only works on WPCOM sites, so I intentionally wanted to include a wpcom mention in both the file and the component name. This will make cause the component to have a different naming than in Calypso.

Said that, I renamed some of the properties, so they are similar to the Calypso ones, and also added support for children components like in Calypso.

I'm also reluctant to adding a generic event tracking to the component like in Calypso, because Jetpack is already tracking events for some of the links outside of the component, but they all use a different event name, so we cannot consolidate that inside the component.

Yes, but that means if we want to see how many clicks have for the help center, we'll have to do an audit of all of these events and maintain that list. Having a generic event would be a lot easier to keep track of and it would be consistent with the behavior we have in Calypso.

Plus, in some scenarios tracking a specific event doesn't always mean that the help center will be opened: the example is the ai-post-excerpt from this PR where for Jetpack sites we don't open the HC.

But first, @escapemanuele do you happen to know if we even care about these events (to be more exact, is someone interested in these values)? :D

However, the link only works on WPCOM sites

Does it make sense to have a component that works for Jetpack too? But instead of opening the HC, it just opens the external link?

This way, if we ever want to ship HC to Jetpack, we don't need to audit the code again.

if we want to see how many clicks have for the help center

if we ever want to ship HC to Jetpack

Two big ifs in there 😄 I'm not a fan of early abstractions and implementing logic for use cases we don't need yet.

haha. But tbf, the first one is more about consistency. We trigger those in Calypso, it would make sense to have it in Jetpack too. 😄

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx

…ivalent to the Calypso counterpart

...jetpack-mu-wpcom/src/features/wpcom-block-description-links/src/description-support-link.tsx

projects/plugins/jetpack/extensions/plugins/seo/components/upsell.js

alshakero

Tested all the steps in English and Arabic and everything worked as expected. The Help Center opens and the right article of the appropriate locale opens 🪄

Notes:

I couldn't manage to see the upsell "To use the SEO feature...". Not sure how you got an Atomic site without a business plan?
The "Block guide" phrase is not translated, probably because it's new.

mmtr · 2025-06-11T15:00:00Z

I couldn't manage to see the upsell "To use the SEO feature...". Not sure how you got an Atomic site without a business plan?

It's easier if you test this on a Simple site with a Free plan.

The "Block guide" phrase is not translated, probably because it's new.

It's not new, since the link already exists in production. Actually, it's also displayed untranslated in production, so it looks like a symptom of something else. Asked in p1749653988642659-slack-C02AED43D

…t-open-support-links-in-help-center-modal

Updates the Help Center app for WP Admin so any support link with a `data-target="wpcom-help-center"` attribute is opened in the Help Center directly rather than in a new tab. This is useful for cases where React is not available and therefore we cannot use the `WpcomSupportLink` component introduced in Automattic/jetpack#43883.

mmtr added 2 commits June 10, 2025 17:01

Post editor: Open support links in Help Center

b3213d2

Add changelog

fa51ecb

mmtr self-assigned this Jun 10, 2025

mmtr added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jun 10, 2025

mmtr requested a review from a team June 10, 2025 15:37

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 10, 2025

mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jun 10, 2025

mmtr added 2 commits June 10, 2025 18:00

Drop TS support since the rest of the package has many TS errors that…

522ff20

… need fixing before

Fix JSDoc

141cb59

rcrdortiz reviewed Jun 10, 2025

View reviewed changes

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx Outdated Show resolved Hide resolved

rcrdortiz requested a review from Copilot June 10, 2025 16:32

Copilot AI reviewed Jun 10, 2025

View reviewed changes

simison mentioned this pull request Jun 10, 2025

Update/wpcom simple payments doc link #43891

Merged

3 tasks

alshakero requested changes Jun 10, 2025

View reviewed changes

...jetpack-mu-wpcom/src/features/wpcom-block-description-links/src/description-support-link.tsx Show resolved Hide resolved

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx Outdated Show resolved Hide resolved

BogdanUngureanu reviewed Jun 11, 2025

View reviewed changes

projects/js-packages/shared-extension-utils/src/components/wpcom-support-link.jsx Show resolved Hide resolved

mmtr added 2 commits June 11, 2025 10:53

Forward missing ref

24892aa

Prevent re-renders

ddb1c3c

Rename props and add support for children components so it's more equ…

d13d8af

…ivalent to the Calypso counterpart

BogdanUngureanu reviewed Jun 11, 2025

View reviewed changes

...jetpack-mu-wpcom/src/features/wpcom-block-description-links/src/description-support-link.tsx Show resolved Hide resolved

BogdanUngureanu reviewed Jun 11, 2025

View reviewed changes

projects/plugins/jetpack/extensions/plugins/seo/components/upsell.js Show resolved Hide resolved

alshakero approved these changes Jun 11, 2025

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into dotsup-57-master-lis…

7287775

…t-open-support-links-in-help-center-modal

mmtr added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jun 12, 2025

mmtr merged commit f8d762d into trunk Jun 12, 2025
76 checks passed

mmtr deleted the dotsup-57-master-list-open-support-links-in-help-center-modal branch June 12, 2025 08:09

github-actions bot added this to the jetpack/14.8 milestone Jun 12, 2025

github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jun 12, 2025

This was referenced Jun 12, 2025

Post editor: Fix support link in SEO upsell #43924

Merged

Add WP Admin util to open support links in Help Center Automattic/wp-calypso#104172

Merged

Post editor: Open support links in Help Center #43883

Post editor: Open support links in Help Center #43883

Uh oh!

Conversation

mmtr commented Jun 10, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

alshakero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BogdanUngureanu Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

mmtr Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

BogdanUngureanu Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmtr Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

BogdanUngureanu Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alshakero left a comment

Choose a reason for hiding this comment

Notes:

Uh oh!

mmtr commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading

jp-launch-control bot commented Jun 10, 2025 •

edited

Loading

BogdanUngureanu Jun 11, 2025 •

edited

Loading