Skip to content

Add WP Admin util to open support links in Help Center #104172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jun 12, 2025

Part of DOTSUP-66
Required by 185363-ghe-Automattic/wpcom and Automattic/jetpack#43930

Proposed Changes

Updates the Help Center app for WP Admin so any support link with a data-target="wpcom-help-center" attribute is opened in the Help Center directly rather than in a new tab.

Screen.Recording.2025-06-12.at.15.35.19.mov

This is useful for cases where React is not available and therefore we cannot use the WpcomSupportLink component introduced in Automattic/jetpack#43883.

Why are these changes being made?

Because it provides a more consistent and quality user experience and it trains users to use the Help Center.

Testing Instructions

git checkout origin/dotsup-66-open-settings-support-links-in-help-center
install-plugin.sh help-center dotsup-66-open-settings-support-links-in-help-center
bin/jetpack-downloader test jetpack dotsup-66-open-settings-support-links-in-help-center
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotsup-66-open-settings-support-links-in-help-center
  • Sandbox widgets.wp.com and a Simple site
  • Go to the following screens, and make sure that the supports links are opened in the Help Center:

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr self-assigned this Jun 12, 2025
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. labels Jun 12, 2025
Copy link

github-actions bot commented Jun 12, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mmtr mmtr requested a review from a team June 12, 2025 14:22
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great design. Simple and does the job. Left one optional note.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotsup-66-open-settings-support-links-in-help-center on your sandbox.

Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with Automattic/jetpack#43949 and works perfectly.

@mmtr mmtr merged commit 0699249 into trunk Jun 13, 2025
11 of 13 checks passed
@mmtr mmtr deleted the dotsup-66-open-settings-support-links-in-help-center branch June 13, 2025 14:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 13, 2025
@alshakero alshakero restored the dotsup-66-open-settings-support-links-in-help-center branch June 13, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants