Simple 7993 deprecated module names #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed type annotations for the convergence wait time
* Add support for a starting index when connecting nodes. By default, the `lab.connect_two_nodes()` connects the next two available indexes. Extend this to allow an index where you can start at, for example, 1. This could allow to skip mgmt interfaces. * Consume the position element. Spotted by: Patrick Mosko --------- Co-authored-by: Joe Clarke <[email protected]>
Switched all __repr__ to f-string; Shortened some __repr__ to only include useful/meaningful info for its purposes. Addressed missing pre-commit tests and incorrect indentation. Simplified node constructor to ease manual use. Modified create node methods accordingly. Addressed unresolved reviews.
* Updated get_diagnostics method to use new endpoints. Returning either selected ones or all by default. * Fixed get_diagnostics (error handling, fixed endpoint construction). Added new unit tests. Co-authored-by: Branislav Taran <[email protected]>
* SIMPLE-7496 Deprecated get_diagnostics with no args Removed unused group permissions Renamed modules (no need to use plural) Fixed indents in docstrings and docstring themselves in a couple of modules
* SIMPLE-7461: initial consolidation of .*NotFound and ElementAlreadyExists exceptions * SIMPLE-7461: implemented fixes based on review * minor cleanup --------- Co-authored-by: Tomas Mikuska <[email protected]>
* SIMPLE-7433 nodes_count added to compute * SIMPLE-7433 nodes_count renamed to node_counts * Deprecated the nodes property --------- Co-authored-by: Tomas Mikuska <[email protected]>
Updated packages
* SIMPLE-7745 - allow .tar.gz image file extension * Path is supported in import_lab_from_path
#151) * SIMPLE-6967 - add pubkey for user create and update, add testbed key_path setting
* added client type identifier * renamed header * added parameter to init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently DeprecationWarning is ignored by default (except by code in main). I doubt users would run their scripts in a mode that enables such warnings. Therefore I also propose to use the default UserWarning instead.