Skip to content

[Mods] Update and expand some special vision IDs #80696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 24, 2025

Summary

Mods "[Mods] Update and expand some special vision IDs"

Purpose of change

I have been informed that adding new ids for special_vision sprites is not just fine, but actually good.

Describe the solution

Update several special_visions that use already-existing sprites to use new sprite IDs.

Add the following ids:

  • vampire_sense (collapsed both vampire and vampire_sense into vampire_sense, since most special_vision ids end in _sense and vampire doesn't seem to have an attached sprite yet)
  • human_sense
  • night_creature_sense
  • wizard_sense

Describe alternatives you've considered

Everything is infrared blobs

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved labels Apr 24, 2025
@github-actions github-actions bot requested review from KorGgenT and Maleclypse April 24, 2025 13:56
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 24, 2025
@Maleclypse Maleclypse merged commit 5660fba into CleverRaven:master Apr 27, 2025
33 checks passed
thaelina pushed a commit to thaelina/Cataclysm-DDA that referenced this pull request Apr 27, 2025
[Mods] Update and expand some special vision IDs
@Standing-Storm Standing-Storm deleted the special-visions branch April 27, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants