-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TF changes for AlloyDB Free trials #11207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF changes for AlloyDB Free trials #11207
Conversation
girdharchirag
commented
Jul 19, 2024
•
edited
Loading
edited
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 72 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests are failing with this error:
The request was invalid: Not eligible to create Free Trial cluster
Do you know how we can fix that?
Yes, I looked into it. We'll have to add the ProjectID to the exception list so that it is eligible to create trial cluster. I have made the required changes but it will take some time for the changes to reach prod. We'll have to wait for that. |
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a review to stop the reminders, please re-request review when this is ready.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 72 Click here to see the affected service packages
Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 72 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 72 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 73 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
The PR is ready for review now. Please review. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 73 Click here to see the affected service packages
View the build log |
trial_metadata is an output only field. I have added checks to verify that it is correctly populated. |
If it's output-only it should be marked as |
Co-authored-by: Sam Levenick <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 73 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_cluster" "primary" {
trial_metadata {
end_time = # value needed
grace_end_time = # value needed
start_time = # value needed
upgrade_time = # value needed
}
}
|
Tests analyticsTotal tests: 73 Click here to see the affected service packages
View the build log |