Skip to content

TF changes for AlloyDB Free trials #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

This PR contains changes for AlloyDB cluster. It adds the subscription type attribute which was missing in Terraform but were present in REST API for this resource and the corresponding tests.

alloydb: added `subscription_type` and `trial_metadata` field to `google_alloydb_cluster` resource

Derived from GoogleCloudPlatform/magic-modules#11207

Co-authored-by: Sam Levenick <[email protected]>

[upstream:8e79c4b6028a4e5ef7542e617388d7ae0eedfe87]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner August 26, 2024 21:14
@modular-magician modular-magician requested review from shuyama1 and removed request for a team August 26, 2024 21:14
@modular-magician modular-magician merged commit 555ee74 into GoogleCloudPlatform:main Aug 26, 2024
4 of 5 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-8e79c4b6028a4e5ef7542e617388d7ae0eedfe87 branch November 18, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant